[PATCH 06/10] RTC subsystem, RS5C372 sysfs fix

[Alessandro Zummo]

 fixed sysfs show() return code

Signed-off-by: Alessandro Zummo <a.zummo@xxxxxxxxxxxx>

---
 drivers/rtc/rtc-rs5c372.c |   18 ++++++++++--------
 1 file changed, 10 insertions(+), 8 deletions(-)

--- linux-rtc.orig/drivers/rtc/rtc-rs5c372.c    2006-03-29 02:41:04.000000000 
+0200
+++ linux-rtc/drivers/rtc/rtc-rs5c372.c 2006-03-29 02:46:40.000000000 +0200
@@ -169,24 +169,26 @@ static struct rtc_class_ops rs5c372_rtc_
 static ssize_t rs5c372_sysfs_show_trim(struct device *dev,
                                struct device_attribute *attr, char *buf)
 {
-       int trim;
+       int err, trim;
 
-       if (rs5c372_get_trim(to_i2c_client(dev), NULL, &trim) == 0)
-               return sprintf(buf, "0x%2x\n", trim);
+       err = rs5c372_get_trim(to_i2c_client(dev), NULL, &trim);
+       if (err)
+               return err;
 
-       return 0;
+       return sprintf(buf, "0x%2x\n", trim);
 }
 static DEVICE_ATTR(trim, S_IRUGO, rs5c372_sysfs_show_trim, NULL);
 
 static ssize_t rs5c372_sysfs_show_osc(struct device *dev,
                                struct device_attribute *attr, char *buf)
 {
-       int osc;
+       int err, osc;
 
-       if (rs5c372_get_trim(to_i2c_client(dev), &osc, NULL) == 0)
-               return sprintf(buf, "%d.%03d KHz\n", osc / 1000, osc % 1000);
+       err = rs5c372_get_trim(to_i2c_client(dev), &osc, NULL);
+       if (err)
+               return err;
 
-       return 0;
+       return sprintf(buf, "%d.%03d KHz\n", osc / 1000, osc % 1000);
 }
 static DEVICE_ATTR(osc, S_IRUGO, rs5c372_sysfs_show_osc, NULL);
 

--
-
To unsubscribe from this list: send the line "unsubscribe linux-kernel" in
the body of a message to majordomo@xxxxxxxxxxxxxxx
More majordomo info at  http://vger.kernel.org/majordomo-info.html
Please read the FAQ at                                  www.tux.org/lkml/">http://www.tux.org/lkml/